Fix legacy long aggregations #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantpark04
force-pushed
the
bryantp/legacy-long-aggregations
branch
from
f7ab49a to
d2419ac
Compare
bryantpark04
commented
Jul 25, 2024
| @@ -111,15 +112,17 @@ export type GroupByFromType<T, N extends string> = NonNullable<T> extends number | |||
| : T extends Array<infer U> ? GroupByFromType<U, N> | |||
| : never; | |||
|
|
|||
| export type AggregationFromType<T> = NonNullable<T> extends number | |||
| export type AggregationFromType<T> = NonNullable<T> extends StringLong | |||
There was a problem hiding this comment.
This is the main change that adds numerical aggregation support back to long-type properties
bryantpark04
commented
Jul 25, 2024
|
|
||
| declare const representsLong: unique symbol; | ||
|
|
||
| export type StringLong = string & { [representsLong]: true }; |
There was a problem hiding this comment.
Used a tagged type to disambiguate between string-type properties and strings that represent long-type properties
There was a problem hiding this comment.
Can we leave a comment in the code here to explain this?
ericanderson
approved these changes
Jul 25, 2024
ssanjay1
approved these changes
Jul 25, 2024
|
Fixes #324 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.